Make SVG scroll-animation tests not rely on dirty-tree snapshot #54882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An HTML PR[1] is attempting to move snapshotting of post-layout state to where the layout tree is actually clean. The test changes here makes them valid both when timelines are updated before the rendering update, and when they are only updated post-layout. [1] whatwg/html#11613 Bug: 384523570 Change-Id: I3332e29c26171815c50fe2a0f16be56fd47276be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950754 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1516452}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6950754
branch
from
8e67c54 to
2d189fe
Compare
wpt-pr-bot
approved these changes
Sep 17, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An HTML PR[1] is attempting to move snapshotting of post-layout state
to where the layout tree is actually clean.
The test changes here makes them valid both when timelines are updated
before the rendering update, and when they are only updated post-layout.
[1] whatwg/html#11613
Bug: 384523570
Change-Id: I3332e29c26171815c50fe2a0f16be56fd47276be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6950754
Reviewed-by: Kevin Ellis <[email protected]>
Commit-Queue: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1516452}