Avoid crash when adopting nodes with event listeners #55454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 15, 2025
servo-wpt-sync
force-pushed
the
servo_export_39901
branch
from
ea7853d to
583e017
Compare
servo-wpt-sync
force-pushed
the
servo_export_39901
branch
2 times, most recently
from
fb90135 to
9fa7234
Compare
servo-wpt-sync
force-pushed
the
servo_export_39901
branch
from
9fa7234 to
b01f154
Compare
Previously we would crash when the event listener runs in the new document, since it was compiled against the global from the old document. Instead, we need to mark all event listeners as uncompiled, so that we reset the global to the new document. It also adds a new WPT test, but it is named tentative since Chrome and Firefox differ in behavior. Fixes web-platform-tests#36397 Signed-off-by: Tim van der Lippe <[email protected]>
servo-wpt-sync
force-pushed
the
servo_export_39901
branch
from
b01f154 to
6e4d995
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would crash when the event listener runs in the new document, since it was compiled against the global from the old document. Instead, we need to mark all event listeners as uncompiled, so that we reset the global to the new document.
It also adds a new WPT test, but it is named tentative since Chrome and Firefox differ in behavior.
Fixes #36397
Reviewed in servo/servo#39901