[BUGFIX] Make copy mode work again #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calien666
force-pushed
the
bugfix/issue-11-copy-mode
branch
2 times, most recently
from
a5a4eed to
774069e
Compare
The newly added structure with LocalizationModes registered as configurable modes through PHP instead of the hard-coded Localization used the `LocalizationController::ACTION_*` constants for detecting the EventListener being responsible for a translation mode. As the JavaScript identifier was taken for the comparison and the identifier was named `copy`, but the compare-to is named `copyFromLanguage`, the condition skipped the EventListener instead of building the command map for the DataHandler to work. Fixes #11
calien666
force-pushed
the
bugfix/issue-11-copy-mode
branch
from
774069e to
a639f83
Compare
sbuerk
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly added structure with LocalizationModes registered as configurable modes through PHP instead of the hard-coded Localization used the
LocalizationController::ACTION_*constants for detecting the EventListener being responsible for a translation mode.As the JavaScript identifier was taken for the comparison and the identifier was named
copy, but the compare-to is namedcopyFromLanguage, the condition skipped the EventListener instead of building the command map for the DataHandler to work.Fixes #11