Skip to content

fix: reachability resolves only after all results instead of 1 per cl… #4438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2025
+161 −6
Merged

fix: reachability resolves only after all results instead of 1 per cl… #4438

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e0893d
fix: reachability resolves only after all results instead of 1 per cl…
marcin-bazyl Aug 13, 2025
8e00f9e
Merge branch 'next' into spark-702198
Shreyas281299 Sep 16, 2025
f84c543
Merge branch 'next' into spark-702198
marcin-bazyl Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/@webex/plugin-meetings/src/reachability/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,10 +923,10 @@ export default class Reachability extends EventsScope {

// update expected results counters to include this cluster
this.expectedResultsCount[cluster.isVideoMesh ? 'videoMesh' : 'public'].udp +=
cluster.udp.length;
cluster.udp.length > 0 ? 1 : 0;
if (!cluster.isVideoMesh) {
this.expectedResultsCount.public.tcp += cluster.tcp.length;
this.expectedResultsCount.public.xtls += cluster.xtls.length;
this.expectedResultsCount.public.tcp += cluster.tcp.length > 0 ? 1 : 0;
this.expectedResultsCount.public.xtls += cluster.xtls.length > 0 ? 1 : 0;
}
});

Expand Down
161 changes: 158 additions & 3 deletions packages/@webex/plugin-meetings/test/unit/spec/reachability/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,14 @@ import MockWebex from '@webex/test-helper-mock-webex';
import sinon from 'sinon';
import EventEmitter from 'events';
import testUtils from '../../../utils/testUtils';
import Reachability, {
ReachabilityResultsForBackend,
} from '@webex/plugin-meetings/src/reachability/';
import Reachability from '@webex/plugin-meetings/src/reachability/';
import {ClusterNode} from '../../../../src/reachability/request';
import MeetingUtil from '@webex/plugin-meetings/src/meeting/util';
import * as ClusterReachabilityModule from '@webex/plugin-meetings/src/reachability/clusterReachability';
import Metrics from '@webex/plugin-meetings/src/metrics';

import {IP_VERSION} from '@webex/plugin-meetings/src/constants';
import { ReachabilityResultsForBackend } from '@webex/plugin-meetings/src/reachability/reachability.types';

describe('isAnyPublicClusterReachable', () => {
let webex;
Expand Down Expand Up @@ -836,6 +835,162 @@ describe('gatherReachability', () => {
},
},
// ========================================================================
{
title: '2 clusters: one with multiple urls, reachability should resolve after the first result for each protocol is ready',
waitShortTimeout: false,
waitLongTimeout: false,
mockClusters: {
cluster1: {
udp: ['udp-url1-1', 'udp-url1-2'],
tcp: ['tcp-url1-1', 'tcp-url1-2'],
xtls: ['xtls-url1-1', 'xtls-url1-2'],
isVideoMesh: false,
},
cluster2: {
udp: ['udp-url2'],
tcp: ['tcp-url2'],
xtls: ['xtls-url2'],
isVideoMesh: false,
},
},
mockResultReadyEvents: [
// results are only for the first url for each protocol not the 2nd one
{
clusterId: 'cluster1',
protocol: 'udp',
result: {
result: 'reachable',
clientMediaIPs: ['1.2.3.4'],
latencyInMilliseconds: 10,
},
},
{
clusterId: 'cluster1',
protocol: 'tcp',
result: {
result: 'reachable',
latencyInMilliseconds: 100,
},
},
{
clusterId: 'cluster1',
protocol: 'xtls',
result: {
result: 'reachable',
latencyInMilliseconds: 200,
},
},
{
clusterId: 'cluster2',
protocol: 'udp',
result: {
result: 'reachable',
clientMediaIPs: ['1.2.3.4'],
latencyInMilliseconds: 20,
},
},
{
clusterId: 'cluster2',
protocol: 'tcp',
result: {
result: 'reachable',
latencyInMilliseconds: 110,
},
},
{
clusterId: 'cluster2',
protocol: 'xtls',
result: {
result: 'reachable',
latencyInMilliseconds: 220,
},
},
],
expectedResults: {
cluster1: {
udp: {result: 'reachable', clientMediaIPs: ['1.2.3.4'], latencyInMilliseconds: 10},
tcp: {result: 'reachable', latencyInMilliseconds: 100},
xtls: {result: 'reachable', latencyInMilliseconds: 200},
isVideoMesh: false,
},
cluster2: {
udp: {result: 'reachable', clientMediaIPs: ['1.2.3.4'], latencyInMilliseconds: 20},
tcp: {result: 'reachable', latencyInMilliseconds: 110},
xtls: {result: 'reachable', latencyInMilliseconds: 220},
isVideoMesh: false,
},
},
expectedMetrics: {
vmn_udp_min: -1,
vmn_udp_max: -1,
vmn_udp_average: -1,
public_udp_min: 10,
public_udp_max: 20,
public_udp_average: 15,
public_tcp_min: 100,
public_tcp_max: 110,
public_tcp_average: 105,
public_xtls_min: 200,
public_xtls_max: 220,
public_xtls_average: 210,
},
},
// ========================================================================
{
title: '1 cluster with zero urls for TCP, reachability should resolve after the first result for each protocol is ready without waiting for TCP',
waitShortTimeout: false,
waitLongTimeout: false,
mockClusters: {
cluster1: {
udp: ['udp-url1'],
tcp: [],
xtls: ['xtls-url1'],
isVideoMesh: false,
},
},
mockResultReadyEvents: [
{
clusterId: 'cluster1',
protocol: 'udp',
result: {
result: 'reachable',
clientMediaIPs: ['1.2.3.4'],
latencyInMilliseconds: 10,
},
},
{
clusterId: 'cluster1',
protocol: 'xtls',
result: {
result: 'reachable',
latencyInMilliseconds: 200,
},
},
],
expectedResults: {
cluster1: {
udp: {result: 'reachable', clientMediaIPs: ['1.2.3.4'], latencyInMilliseconds: 10},
tcp: {result: 'untested'},
xtls: {result: 'reachable', latencyInMilliseconds: 200},
isVideoMesh: false,
},
},
expectedMetrics: {
vmn_udp_min: -1,
vmn_udp_max: -1,
vmn_udp_average: -1,
public_udp_min: 10,
public_udp_max: 10,
public_udp_average: 10,
public_tcp_min: -1,
public_tcp_max: -1,
public_tcp_average: -1,
public_xtls_min: 200,
public_xtls_max: 200,
public_xtls_average: 200,
},
},
// ========================================================================
{
title: '2 clusters: both with no results at all',
waitShortTimeout: 'public',
Expand Down
Loading