-
Notifications
You must be signed in to change notification settings - Fork 377
fix(kms): test pipeline, reformat uploadCustomerMasterKey #4442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe change reformats the parameter list of the public method uploadCustomerMasterKey in packages/@webex/internal-plugin-encryption/src/kms.js from a single-line destructured object to a multi-line format. Default values (awsKms = false, customerMasterKeyBackup = undefined) remain unchanged. No logic, control flow, or behavior modifications are present. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/@webex/internal-plugin-encryption/src/kms.js (1)
274-281
: Nit: Align JSDoc @param order with the current parameter destructuringOrder doesn’t affect behavior for a destructured object, but keeping docs aligned with the signature reduces confusion for readers and tooling.
Proposed tweak:
* @param {Object} options * @param {UUID} options.assignedOrgId the orgId * @param {string} options.customerMasterKey the master key - * @param {string} options.customerMasterKeyBackup the master key backup - * @param {boolean} options.awsKms enable amazon aws keys + * @param {boolean} options.awsKms enable amazon aws keys + * @param {string} options.customerMasterKeyBackup the master key backup
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/@webex/internal-plugin-encryption/src/kms.js
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Initialize Project
🔇 Additional comments (1)
packages/@webex/internal-plugin-encryption/src/kms.js (1)
282-287
: LGTM: purely stylistic reformat of parameter destructuringThe multi-line destructuring with defaults preserves behavior and improves readability. No functional changes introduced.
testing pipeline to see if failing tests are real or not. just format to multi-line