-
Notifications
You must be signed in to change notification settings - Fork 379
feat(contact-center): added-consult-transfer-to-dn #4468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhmenon
commented
Sep 11, 2025
adhmenon
commented
Sep 11, 2025
adhmenon
commented
Sep 11, 2025
rsarika
reviewed
Sep 15, 2025
rsarika
approved these changes
Sep 15, 2025
Shreyas281299
approved these changes
Sep 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, I just have a few non blocking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #< AD-HOC >
This pull request addresses
consultTransfer
to a queue with a dialNumberby making the following changes
destinationType
from the backend event data so we can ascertain if it is a dial number or basic queue consultTransfer.Tested With Arun
Vidcast - https://app.vidcast.io/share/6ca2f871-9540-4d40-a55d-110ed84b9d83
(Working even for accept consult case, UI issues in vidcast are known and are sample app related.. have been fixes with task refactor).
Change Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.