Skip to content

Conversation

adhmenon
Copy link
Contributor

@adhmenon adhmenon commented Sep 11, 2025

COMPLETES #< AD-HOC >

This pull request addresses

  • Currently in the CC SDK, we do not directly support consultTransfer to a queue with a dialNumber
  • We also are overriding certain task data on queue consult, this is causing issues.

by making the following changes

  • Extract the destinationType from the backend event data so we can ascertain if it is a dial number or basic queue consultTransfer.
  • Fixed the overriding of TaskData on AGENT_CONSULTING event as this was redundant and interfering with everything.

Tested With Arun

Vidcast - https://app.vidcast.io/share/6ca2f871-9540-4d40-a55d-110ed84b9d83

(Working even for accept consult case, UI issues in vidcast are known and are sample app related.. have been fixes with task refactor).

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • Tested basic call control and consult transfer

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Cursor
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@adhmenon adhmenon requested a review from a team as a code owner September 11, 2025 13:15
@adhmenon adhmenon added the validated If the pull request is validated for automation. label Sep 11, 2025
@adhmenon adhmenon changed the title DUMMY_PR: Added transfer to DN (via queue) feat(contact-center): added-consult-transfer-to-dn Sep 11, 2025
@adhmenon adhmenon requested a review from rsarika September 15, 2025 04:38
Copy link
Contributor

@Shreyas281299 Shreyas281299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, I just have a few non blocking changes.

@adhmenon adhmenon merged commit ed236cc into webex:next Sep 15, 2025
11 checks passed
@adhmenon adhmenon deleted the queue-dn branch September 15, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants