Skip to content

Conversation

@venky-mediboina
Copy link
Contributor

@venky-mediboina venky-mediboina commented Oct 16, 2025

COMPLETES #SPARK-610518

This pull request addresses

Saving the subnet ip details which includes subnet IPs, latency, etc..

by making the following changes

Saved the subnet ip details in reachability results and sending to web-client, implements each UDP URL checks for Reachability.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@venky-mediboina venky-mediboina requested review from a team as code owners October 16, 2025 08:34
@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4542.d3m3l2kee0btzx.amplifyapp.com

@venky-mediboina
Copy link
Contributor Author

Added extra fields in the Reachability Results like details (includes subnet's IP, latency, answered-tx, lost-tx, port) , minLatency, and other fields for each protocol in cluster.

Implemented Per URL check for UDP, triggering based on the flag(reachabilityEnablePerUrlForUdp) in config.ts. Took a separate class (SubnetReachabilityChecker) and used that class for every UDP URL from CLusterReachability class.

Sample Results when reachabilityEnablePerUrlForUdp: true:
Reachability Results(when flag true).json

Sample Results when reachabilityEnablePerUrlForUdp: false:
Reachability Results(when flag false).json

@marcin-bazyl marcin-bazyl added the validated If the pull request is validated for automation. label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants