fix(calling): fix the ExtendedError usage in logs and UTs

[rarajes2]

COMPLETES #< CAI-7234 >

This pull request addresses

We were using the ExtendedError just for the typecasting to match the param type for logger.error. The logger.error was also accepting the 2nd param for context (file and method name) and we are passing that info everywhere so using the ExtendedError type was not required. From the first argument of logger.error as error object we were simply using the error.message to print the log so, now we are simply passing the error message and printing it directly. Keeping it consistent with all other logger methods and reducing the boilerplate.

Also stringifying the error object so that we don't get [object Object] in the logs.

by making the following changes

Error logs are cleanly added now.

Change Type

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update
• Tooling change
• Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

• GAI was not used (or, no additional notation is required)
• Code was generated entirely by GAI
• GAI was used to create a draft that was subsequently customized or modified
• Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
• Tool used for AI assistance (GitHub Copilot / Other - specify)
  • Github Copilot
  • Other - Please Specify
• This PR is related to
  • Feature
  • Defect fix
  • Tech Debt
  • Automation

I certified that

• I have read and followed contributing guidelines
• I discussed changes with code owners prior to submitting this pull request
• I have not skipped any automated checks
• All existing and new tests passed
• I have updated the documentation accordingly

---

Make sure to have followed the contributing guidelines before submitting.

[adhmenon]

Changes LGTM.
Can we have a ss showing some of the updated logs? Just to verify the shape.

[Kesari3008]

Quick question, we still have ExtendedError being used by LinError, CallError to crea the call object. Is that code still relevant ? Do we still need it ? Did we only need to remove the typecasting ?
Also can we test basic error cases where we have made change and add that for testing proofs

[Kesari3008]

Won't call.test.s file require changes for these ?

[rarajes2]

This is a private method and not being called anywhere inside this file. We can discuss and remove this method itself if it's not required

[Kesari3008]

I meant changes for the error message changing. Do we have error spy for these logs created in test files and being checked. If not we should add

[rarajes2]

Quick question, we still have ExtendedError being used by LinError, CallError to crea the call object. Is that code still relevant ? Do we still need it ? Did we only need to remove the typecasting ? Also can we test basic error cases where we have made change and add that for testing proofs

ExtendedError is used in CallError and LineError and they are being used in the error handling methods. Typecasting was unnecessary

[Kesari3008]

Approving the PR.
But please add the log spy for log.error and log.log occurrences as it is crucial. One of the point was this in the acceptance criteria of Jira