fix(meetings): checking audio level from RTP header before emitting DECODE_RESULTS_IN_ZERO_AUDIO_LEVEL #4550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-bazyl
force-pushed
the
spark-728621
branch
from
481fa74 to
15164b1
Compare
marcin-bazyl
commented
Oct 29, 2025
| RemoteStreamEventNames, | ||
| type VideoContentHint, | ||
| type StreamState, | ||
| type InboundAudioIssueEvent, |
There was a problem hiding this comment.
these exports is something I missed in some previous PRs, web app needs them (for now it's importing them directly from internal-media-core, but really it should do it via SDK)
marcin-bazyl
force-pushed
the
spark-728621
branch
from
c50f7b0 to
ac9fce5
Compare
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
arun3528
changed the title
antsukanova
reviewed
Nov 5, 2025
|
|
||
| testEnableInboundAudioLevelMonitoring( | ||
| 'enables enableInboundAudioLevelMonitoring for multistream when browser is Chrome', | ||
| {isChrome: true, isEdge: false}, |
There was a problem hiding this comment.
why do you need to pass isEdge: false?
There was a problem hiding this comment.
yeah, it's redundant, it's something left over from a previous version of the code where these were required, I've removed it now
antsukanova
approved these changes
Nov 5, 2025
marcin-bazyl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-728621
This pull request addresses
We incorrectly detect issues with remote audio level being zero when remote participants are unmuted but silent.
by making the following changes
Updating to latest internal-media-core (which includes new WCME) that only emits the INBOUND_AUDIO_ISSUE event with sub type DECODE_RESULTS_IN_ZERO_AUDIO_LEVEL when decoded audio level is zero while audio level in rtp header extension is not zero - this should minimize the false positives for these audio issue events we're seeing from our metrics.
This PR depends on:
Change Type
The following scenarios where tested
unit tests, manual testing with WCME and web app
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.