-
Notifications
You must be signed in to change notification settings - Fork 385
feat(calling): fixed-double-media-request #4556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| await flushPromises(2); | ||
| expect(call.isConnected()).toBe(false); | ||
|
|
||
| expect(call['mediaStateMachine'].state.value).toBe('S_ROAP_ERROR'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this change needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was failing... and I removed it because it was not testing the correct flow.
It was tryng to test media error without mocking it... but can check this further.
rarajes2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test to cover the case where it covers the if condition
rarajes2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Existing test has the message.messageType as ERROR which covers the case
COMPLETES #< https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7272 >
This pull request addresses
handleRoapErrorby making the following changes
ifcheck inhandleRoapErrorto only post actual ERRORS from media core to mobiusVidcast - https://app.vidcast.io/share/d7377177-c7aa-4e64-a44a-694e71daf0d3
Change Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.