Skip to content

Conversation

@adhmenon
Copy link
Contributor

COMPLETES #< https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7272 >

This pull request addresses

  • During the mobius chaos testing, a small issue was found with the SDK during the answerOffer phase.
  • The SDK was sending a media request ot mobius even after delete.
  • The reason was because of a check we were not doing in our handleRoapError

by making the following changes

  • Added a minor if check in handleRoapError to only post actual ERRORS from media core to mobius
Screenshot 2025-10-29 at 2 06 19 PM

Vidcast - https://app.vidcast.io/share/d7377177-c7aa-4e64-a44a-694e71daf0d3

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • Tested the same TC as mobius team did.
  • Tested basic outgoing call.

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@adhmenon adhmenon requested a review from a team as a code owner October 31, 2025 04:31
@adhmenon adhmenon added the validated If the pull request is validated for automation. label Oct 31, 2025
@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4556.d3m3l2kee0btzx.amplifyapp.com

await flushPromises(2);
expect(call.isConnected()).toBe(false);

expect(call['mediaStateMachine'].state.value).toBe('S_ROAP_ERROR');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing... and I removed it because it was not testing the correct flow.
It was tryng to test media error without mocking it... but can check this further.

@adhmenon adhmenon requested a review from Kesari3008 November 3, 2025 05:48
Copy link
Contributor

@rarajes2 rarajes2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to cover the case where it covers the if condition

Copy link
Contributor

@rarajes2 rarajes2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Existing test has the message.messageType as ERROR which covers the case

@adhmenon adhmenon merged commit 05b8a4c into webex:next Nov 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants