Skip to content

Conversation

@Wojdylak
Copy link
Contributor

@Wojdylak Wojdylak commented Oct 31, 2025

Based on #76

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the plugin from Sylius 1.x to Sylius 2.0, introducing LiveComponents architecture and updating dependency versions.

Key changes include:

  • Upgraded PHP requirement from 8.0 to 8.2 and Symfony from 5.4+ to 6.4+/7.3+
  • Replaced custom JavaScript with Symfony UX LiveComponent for form handling
  • Introduced factory and processor patterns for subscription creation
  • Migrated from SyliusUi events to Twig Hooks for template rendering

Reviewed Changes

Copilot reviewed 148 out of 171 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
composer.json Updated PHP, Symfony, and Sylius version constraints; removed psalm dependency
config/services.yaml Updated service definitions to remove deprecated availability checker references and add new processor/component services
src/Twig/Component/AddNotificationComponent.php New LiveComponent replacing JavaScript-based form handling
src/Factory/SubscriptionFactory.php New factory implementing subscription creation logic extracted from controller
src/Processor/SubscriptionProcessor.php New processor centralizing subscription business logic
src/Controller/SubscriptionController.php Simplified by removing subscription creation logic moved to processor
templates/shop/product/show/content/info/summary/add_notification.html.twig New template using LiveComponent architecture
config/twig_hooks/** New Twig Hooks configuration replacing deprecated SyliusUi events
tests/Application/** Removed old test application files in favor of sylius/test-application package
behat.yml.dist Updated paths to use sylius/test-application
Comments suppressed due to low confidence (1)

src/Twig/Component/AddNotificationComponent.php:1

  • Extra space and asterisk in PHPDoc comment. Should be /** @var ProductVariantInterface|null $variant */

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Wojdylak Wojdylak force-pushed the upgrade-2-0 branch 5 times, most recently from 59dfccb to 3aac1ed Compare October 31, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant