fix: Update jiti from v1 to v2
#710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askoufis
commented
Aug 31, 2025
| tsLoader = (filepath) => jiti(filepath); | ||
| const jiti = createJiti(__filename, opts); | ||
|
|
||
| tsLoader = (filepath) => jiti.import(filepath, { default: true }); |
There was a problem hiding this comment.
default: true is effectively a shorthand for mod?.default ?? mod (docs). It was required to get tests passing, specifically the cts and mts config autoload tests. I'm not exactly sure why this is necessary now - perhaps due to some changes in how interopDefault works in v2.
alexander-akait
approved these changes
Sep 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #710 +/- ##
==========================================
- Coverage 88.30% 88.23% -0.07%
==========================================
Files 3 3
Lines 359 357 -2
Branches 118 118
==========================================
- Hits 317 315 -2
Misses 38 38
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexander-akait
merged commit 9c74974
into
webpack-contrib:master
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Wasn't sure if this really counts as a code refactor. It's really a dependency update but there's no checkbox for that.
Jiti v2 has been out for a while now. Other than the slightly different API usage and deprecation of the synchronous API, it's functionally the same.
Breaking Changes
Additional Info