Add opaqueOverride option to prop object handling #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krisztiaan
force-pushed
the
add-opaque-prop-escape-hatch
branch
from
bcc1e1a to
455bc86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using react-native-reanimated, this library will spread, and traverse SharedValue and DerivedValue objects, causing a warning due to render-time access to reanimated value.
This addition let's the user add
opaqueOverride, so that they can tell the comparator and logger not to bother deep checking certain stuff.Currently I'm getting a console grouping warning in the app while testing, going to have to take a look at that, hence the draft.
Also, this might slightly but not necessarily conflict with having custom comparator override.