fix: compute proper chainId value on useReadConstracts to avoid unnecessary queryKey mutations #4657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essary queryKey mutations Derives a unified chainId from contracts when all share the same value, otherwise falls back to the default (chainId from useChainId). This fixes 'queryKey' mutation when connecting or changing network despite all contracts sharing the same chainId, avoid unnecessary mutations and equating to the default behaviour on useReadContract.
🦋 Changeset detectedLatest commit: 90c66c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tmm
force-pushed
the
main
branch
4 times, most recently
from
dbb8093 to
5937456
Compare
jxom
force-pushed
the
main
branch
2 times, most recently
from
27f0d04 to
7d15f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: compute proper chainId value on useReadConstracts to avoid unnecessary queryKey mutations
Derives a unified chainId from contracts when all share the same value, otherwise falls back to the default (chainId from useChainId).
This fixes 'queryKey' mutation when connecting or changing network despite all contracts sharing the same chainId, avoid unnecessary mutations and equating to the default behaviour on useReadContract.