-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: update .connect to .mutate #4686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Ideally we could extend this in the following ways:
- Remove
'mutate' | 'mutateAsync'from being omitted from the query return type (React, Vue) - Add
@deprecatedcomments to theXMutateandXMutateAsynctype helpers (e.g.ConnectMutateandConnectMutateAsync) - Add
mutate/mutateAsyncfor all mutation hooks (along with the above and@deprecatedcomments for named return methods)
You are welcome to work on this or I can merge you PR into another branch and do this when I get some time.
05e353c to
ded2ee4
Compare
dbb8093 to
5937456
Compare
27f0d04 to
7d15f06
Compare
useConnect():.connectand.connectAsync,.mutateand.mutateAsync,mutate,connecttomutatein docs for Vue and ReactuseDisconnect():.disconnectand.disconnectAsync,.mutateand.mutateAsync,mutate,disconnecttomutatein docs for Vue and React