Add lightning to the safelisted schemes list #11649
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please re-add the PR template that you deleted. |
domenic
added
addition/proposal
|
Ok sorry it's back in place now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium maintainers suggested I open a request here to add lightning: to the list of safelisted schemes. It's a protocol supported by many bitcoin lightning network wallets including the following:
https://www.walletofsatoshi.com/
https://blitz-wallet.com/
https://phoenix.acinq.co/
https://coinos.io/
https://zeusln.com/
https://blixtwallet.github.io/
My motivation for adding it to the safelist is so that PWA's can register to handle it as well.
(See WHATWG Working Mode: Changes for more details.)
/acknowledgements.html ( diff )
/system-state.html ( diff )