Improve optgroup's list of option elements #11738
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that optgroups need to look through their descendants to find option elements, the definition of an optgroup's options just being its children option elements is no longer correct. This PR changes that definition to use the same algorithm that the select element uses to collect its option elements, which incorporates nesting options inside other options, optgroups, and selects. Fixes whatwg#11730
zcorpan
requested changes
Oct 3, 2025
Comment on lines
56196
to
+56198
| <li><p><var>node</var> is an <code>optgroup</code> element and <var>node</var> has an | ||
| <span>ancestor</span> <code>optgroup</code> in between itself and <var>select</var>,</p></li> | ||
| </ul> | ||
| <span>ancestor</span> <code>optgroup</code> in between itself and | ||
| <var>element</var>,</p></li> </ul> |
There was a problem hiding this comment.
When running these steps for an optgroup element, the second check should be skipped, right? Otherwise options in optgroup in optgroup will be returned by the outer optgroup's "descendant option elements".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that optgroups need to look through their descendants to find option elements, the definition of an optgroup's options just being its children option elements is no longer correct. This PR changes that definition to use the same algorithm that the select element uses to collect its option elements, which incorporates nesting options inside other options, optgroups, and selects.
Fixes #11730
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )