Put service-binding dependency under agent feature
#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mat Jones <[email protected]>
|
Yep. Excellent idea. There's just one unrelated issue with a yanked crate. I'll adjust it tomorrow and we can merge this PR and release a new version. Thanks for your contribution! 👋 |
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Update `futures-util` dependency to avoid using yanked crate
|
Okay, since #93 has been merged this could be rebased on top of |
wiktor-k
approved these changes
Oct 25, 2024
|
Done! Thanks for the quick turnaround! |
|
No problem. I've released v0.5.1 with your change: https://crates.io/crates/ssh-agent-lib/versions Thanks for the contribution and have a nice day! 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Over at 1Password, we're looking into replacing
ssh-agent.rswith this library. However, we're mainly just using theprotoandcodecmodules (e.g. we usedefault-features = false, features = ["codec"]). It looks like theservice-bindingdependency is only used in theagentfeature, and since we aren't using it, we'd like to avoid pulling it into our dependency tree.This PR makes
service-bindingoptional and pulls it in via theagentfeature.