[WPB-20053] De-duplicate {brig,galley} api access effects from spar into wire-subsystems. #4840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create scim user group in subsystem.
createScimGroupImpl (wip)
Unit tests, mostly.
More unit test stuff.
Test works: create scim user group, get it back.
Add failing unit test (no non-scim users in scim groups).
Make unit test pass (wip).
Add pending test case for getScimGroup.
Tweak probability distribution over test cases.
Fix typo
Better name for effect action.
Connect scim subsystem to api in spar. (wip)
rm unused library import in spar.cabal
update obsolete comment
hook scim subsystem into spar. (wip)
Extend spar env to handle scim subsystem. (wip)
drive-by refactoring.
ScimSubsystem error handling in spar.
Fixup
Add effects to spar: GalleyAPIAccess, TeamSubsystem
Removed TODO (this is not what we should focus on!)
Fill in more effects in Spar.CanonicalInterpreter.
Add {user,auth}subsystem to spar.
Entire code base: rework error handling [WIP]
fixup
check point: spar compiles with undefineds
fix: complete most of the interpreters
Blindly fix some compiler errors.
Transplanting AWS code out of brig into wire-subsystems [WIP]
fix: Wire.EmailSending.Core
fail with strategy
fix: Wire.EmailSending.Core & Wire.AWSSubsystem.AWS
fix: bind AWSSubsystem
refactor: migrate Queue/DeleteQueue
refactor: move Events
refactor: move more stuff and complete the interpreters stack
start fetching options (missing ES)
ES binding
fix: missing config
fix: integration test config
fix: deduplicate resources
...
eyeinsky
changed the base branch from
develop
to
WPB-20053-scim-groups-create-2
fisx
force-pushed
the
WPB-20053-scim-groups-create-2
branch
2 times, most recently
from
c5929df to
69310c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-20053
Checklist
changelog.d