Fix world prop exploit.

[Zvbhrf]

1. ent_create gmod_wire_simple_explosive SOMEMODEL.mdl
2. Use default duplicator to copy & past this entity.
3. Errors in console.

It turns World in some prop protection addons.

[Zvbhrf]

I got the instructions from this screen.
https://clideo.com/files/images/13N2PvAAn2X6/1JTmuT3p7nBT.png

[wrefgtzweve]

This looks like something that'd affect all wiremod entities, why fix it for this instance specifically?

[wrefgtzweve]

This was patched in advdupe2 before see, wiremod/advdupe2#417
Ideally gmods duplicator should account for this too as it can be triggered with any addon having dupeable entities.

[Zvbhrf]

This looks like something that'd affect all wiremod entities, why fix it for this instance specifically?

I just fixed this using a call stack I got from error. I didn't know that all entities may be affected.

[Zvbhrf]

Ideally gmods duplicator should account for this too as it can be triggered with any addon having dupeable entities.

I'll try to do that a bit later. I thought it was wiremod's issue specifically.

[Astralcircle]

Yes, it won't fix anything, this happens with almost all wire/regular sents. It's more of a problem with the duplicator itself and the long-ignored problem of dupes without data validation

[Zvbhrf]

Yes, it won't fix anything, this happens with almost all wire/regular sents. It's more of a problem with the duplicator itself and the long-ignored problem of dupes without data validation.

Should we approve the PR now? Like this SENT is used widely to created world props, so I think it might work as a temporary "fix" . It's on yours side though.

[Astralcircle]

Nah, there was exactly the same pr from redox to fix turrets, but in the end it didn't fix anything. It's better to make one big PR that will validate all the data of all entities. But it will still error with a regular duplicator because it merges the entity table with the table from the dupe, which can also be corrupted
You can even do this with vanilla gmod sents

[thegrb93]

Yeah this is a Garry's Fault issue

[thegrb93]

However, 'ENT:Setup' should be reworked to have typechecking internally.

[Astralcircle]

Are you still planning anything with this PR? At this stage, i don't see the point, because as i said, it won't fix anything

[Zvbhrf]

Are you still planning anything with this PR? At this stage, i don't see the point, because as i said, it won't fix anything

Probably no if that is a gmod issue.

[Zvbhrf]

I don't think duplicator will be fixed any time soon, so I did that as a "quick fix", so that players won't exploit this on my servers. I just don't think they'll find out that other entities are getting broken like the explosive.

[Astralcircle]

Well, then fork it and fix it yourself. As i said, it doesn't make sense if you only do it for one entity. (even if for every sent ¯_(ツ)_/¯)