feat(pricing-plans): rename props, add more data to PlanPaywall #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous field name 'requiredPlanIds' was misleading as it suggested content was restricted BY those plan IDs. In reality, content in PlanPaywall.RestrictedContent is locked by default and gets UNLOCKED when the member has one of the specified plan IDs. The new name 'accessPlanIds' clearly indicates these IDs grant access to otherwise restricted content, making the API more intuitive. Changes: - Updated PlanPaywallServiceConfig interface - Updated service logic and component examples - Updated API documentation and demo applications - Rebuilt package with new field name
lukasmisiunas
force-pushed
the
refactor/rename-required-plan-ids-to-access-plan-ids
branch
from
387beed to
1ede2c6
Compare
lukasmisiunas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlanPaywallfromrequiredPlanIdstoaccessPlanIdsto better indicate that the restricted content it not locked by the plans, but rather that it's unlocked by the plans. This should make the component/service API more clear and remove ambiguity when providing and empty arrayaccessPlanIdsandisLoggedIntoPlanPaywall.Fallback, so the consumer implementation is more convenientdata-attributes for components that don't render DOM elements by default