refactor(ESModules): replace requires by imports in source files #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnBerd
commented
Mar 27, 2025
Comment on lines
+1
to
+4
| declare module '*.png' { | ||
| const value: import('react-native').ImageSourcePropType; | ||
| export default value; | ||
| } |
There was a problem hiding this comment.
Without this file, typescript does not allow to import png
JohnBerd
commented
Mar 27, 2025
Comment on lines
+1
to
+4
| import XDateClass from 'xdate'; | ||
| import {toMarkingFormat} from './interface'; | ||
|
|
||
| const XDate = XDateClass as any; |
There was a problem hiding this comment.
require types modules as any, since this change is leading to a lot of typing problems, I prefered to keep the same behavior as before
|
I need to know if it is worth resolving conflicts or this should be closed |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is incompatible with storybook 8+ with
vitebecauserequireis not allowed inES modules.Fixes #2396