Skip to content

fix: 🐛 status bar manager issue with new rn fabric #3425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix: 🐛 status bar manager issue with new rn fabric #3425

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9e83b5
fix: 🐛 status bar manager issue with new rn fabric
sivantha96 Oct 29, 2024
d9758dc
added handling for backwards support
nitzanyiz Nov 27, 2024
82b69eb
reverted test change
nitzanyiz Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/commons/Constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import {
NativeModules,
I18nManager,
AccessibilityInfo,
AccessibilityChangeEvent
AccessibilityChangeEvent,
StatusBar
} from 'react-native';

export enum orientations {
Expand Down Expand Up @@ -34,14 +35,14 @@ let breakpoints: Breakpoint[];
let defaultMargin = 0;

const isSubWindow = windowWidth < screenWidth;
//@ts-ignore
isTablet = Platform.isPad || (getAspectRatio() < 1.6 && Math.max(screenWidth, screenHeight) >= 900);
isTablet =
(Platform.OS === 'ios' && Platform.isPad) || (getAspectRatio() < 1.6 && Math.max(screenWidth, screenHeight) >= 900);

function setStatusBarHeight() {
const {StatusBarManager} = NativeModules;
statusBarHeight = StatusBarManager?.HEIGHT || 0; // So there will be a value for any case
if (isIOS) {
statusBarHeight = (StatusBar.currentHeight ?? StatusBarManager?.HEIGHT) || 0;

if (isIOS && StatusBarManager) {
// override guesstimate height with the actual height from StatusBarManager
StatusBarManager.getHeight((data:{height:number}) => (statusBarHeight = data.height));
}
Expand Down Expand Up @@ -125,7 +126,7 @@ const constants = {
return screenHeight <= 600;
},
get isWideScreen() {
return isTablet && !isSubWindow || this.isLandscape;
return (isTablet && !isSubWindow) || this.isLandscape;
},
get screenAspectRatio() {
return getAspectRatio();
Expand Down