Skip to content

Conversation

gojimmypi
Copy link
Contributor

@gojimmypi gojimmypi commented Nov 19, 2024

The PR updates the existing realm-commit-a5e87a39.patch file with my dev-consolidated changes (a pseudo commit-squash), with my actual development branch on my realm-core/tree/dev, improving wolfSSL integration with the realm-core repository.

The update to realm-core is still a patch file here and applied in the build_wolfssl_with_realm.sh script, pending merge of wolfSSL changes at that repository.

Changes are consistently applied from the upstream a5e87a39 commit at this time. Sync to upstream master is planned.

Also included are some of the initial changes for Windows / Visual Studio build support. See also my osp dev branch that contains WIP realm/VS2022 updates, not included in this PR.

The build_wolfssl_with_realm.sh is also updated with many changes including additional parameterized settings, output status verbosity, a new -u option to default to user-specific fork clones & naming, error checking, and more.

  • edit: Note my wolfssl was built and installed to my WSL ~/wolfssl-install-dir directory.

See WOLFSSL_INSTALL_DIR="$HOME/wolfssl-install-dir" setting in build_wolfssl_with_realm.sh script and adjust as needed.

@dgarske dgarske requested review from JacobBarthelmeh and removed request for dgarske November 19, 2024 23:08
@dgarske dgarske assigned wolfSSL-Bot and unassigned gojimmypi Nov 19, 2024
Copy link
Contributor

@jpbland1 jpbland1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been using it, works great

@jpbland1 jpbland1 merged commit bcd7dd9 into wolfSSL:master Jan 15, 2025
@gojimmypi
Copy link
Contributor Author

Awesome. Thanks for the merge!

As noted in #228, I have additional changes coming soon for Visual Studio that will build on this PR.

Latest code is at https://github.com/gojimmypi/osp/tree/dev and will be consolidated in the pr-realm-vs2022 branch. New PR soon after more testing.

See realm/lib/osp_test.bat and realm/build_wolfssl_with_realm.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants