Skip to content

Conversation

padelsbach
Copy link
Contributor

@padelsbach padelsbach commented May 27, 2025

@julek-wolfssl
Copy link
Member

How did you generate the patch?

@padelsbach
Copy link
Contributor Author

How did you generate the patch?

I made edits to the hostap project to get the tests to run, then captured it with git diff.

@padelsbach
Copy link
Contributor Author

padelsbach commented May 27, 2025

How did you generate the patch?

I made edits to the hostap project to get the tests to run, then captured it with git diff.

The patch contains large test vectors from this repo: https://github.com/pyca/cryptography.git

I could probably move those to the CI flow to reduce the size of the patch.

@padelsbach
Copy link
Contributor Author

I could probably move those to the CI flow to reduce the size of the patch.

Done. Much smaller patch now.

@julek-wolfssl
Copy link
Member

A lot of this looks like it would be solved with defining CONFIG_TLS=openssl in the hostapd configuration. Can you post the .config file?

@padelsbach
Copy link
Contributor Author

A lot of this looks like it would be solved with defining CONFIG_TLS=openssl in the hostapd configuration. Can you post the .config file?

The unit tests builds the internal hostapd crypto code as a library and then calls into it. So the top level builds which use the .config file are not used for the unit tests. My solution was to rip out anything that conflicted/duplicated openssl functions.

Maybe there is a cleaner way?

@julek-wolfssl
Copy link
Member

Please specify which unit tests exactly you're talking about.

@padelsbach
Copy link
Contributor Author

Please specify which unit tests exactly you're talking about.

They are under hostap/tests. I run them with make run-tests.

@julek-wolfssl
Copy link
Member

I see it. Unfortunately, those tests barely test anything. The directory tests/hwsim contain much better tests that test the entire stack. Message me if you need help setting that up.

@padelsbach
Copy link
Contributor Author

I see it. Unfortunately, those tests barely test anything. The directory tests/hwsim contain much better tests that test the entire stack. Message me if you need help setting that up.

Ok, I will take a look

@padelsbach
Copy link
Contributor Author

I see it. Unfortunately, those tests barely test anything. The directory tests/hwsim contain much better tests that test the entire stack. Message me if you need help setting that up.

Ok, I will take a look

@julek-wolfssl I am still working on the hwsim as a background task. In the meantime, can we move forward with this one?

@padelsbach
Copy link
Contributor Author

@julek-wolfssl I am still working on the hwsim as a background task. In the meantime, can we move forward with this one?

@julek-wolfssl, any issues with proceeding with this PR?

@julek-wolfssl
Copy link
Member

@ColtonWilley was going to work with you regarding hostap. Pleased coordinate with him now.

@julek-wolfssl julek-wolfssl removed their request for review July 21, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants