Add wolfCrypt sample on RH850 using CS+ #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a wolfCrypt sample for Renesas RH850 using the CS+ environment. Key changes include configuration macros in user_settings.h, implementation of RSA-PSS signing and verification in rsapss.c (with support for both RSA2048 and RSA3072), custom string I/O routines in rh_string.c/h, and necessary boot and startup files for the target device.
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Renesas/cs+/RH850/rsapss_sign_verify/user_settings.h | Added configuration macros for wolfCrypt; duplicate definitions detected. |
| Renesas/cs+/RH850/rsapss_sign_verify/rsapss.c | Implements RSA-PSS sign/verify sample; potential issue with decryption buffer declaration. |
| Renesas/cs+/RH850/rsapss_sign_verify/main.c | Integrates the sample into a startup flow; contains a minor typo. |
| Other files (rsa_private_.c, rh_string., boot.asm, cstart.asm, README.md) | Added support files and documentation for the new sample. |
dgarske
requested changes
Jun 19, 2025
miyazakh
force-pushed
the
rh850_sign_example
branch
from
9a87132 to
0ad1850
Compare
dgarske
requested changes
Jun 25, 2025
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Please squash to remove the intermediate commits with Renesas code.
miyazakh
force-pushed
the
rh850_sign_example
branch
from
0ad1850 to
932dbf7
Compare
dgarske
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.