-
Notifications
You must be signed in to change notification settings - Fork 217
Upgrading node to v20 #4670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Upgrading node to v20 #4670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @wjrosa... Node 20 woohoo! 👏🏼 😄 👏🏼
The changes look good, and it works as expected:
- all checks pass
- tests run locally
- npm start and npm run build work (both after update and with a clean install)
- woorelease simulate generates a valid zip package
@@ -172,8 +175,8 @@ | |||
"changelog": "node bin/changelog.js" | |||
}, | |||
"engines": { | |||
"node": ">=16.17.0", | |||
"npm": ">=8.15.0" | |||
"node": ">=20.10.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the same version as in the .nvmrc
file?
Fixes STRIPE-446
Original PR #4264
Changes proposed in this Pull Request:
This is the main PR upgrading the extension Node version to 20. It is basically a recreation of #4264. The purpose is to keep the git history here cleaner, making it easier to review.
After upgrading many necessary packages, the ones we are upgrading here require Node 20, so they must go along with the main version change.
Testing instructions
dev/node-20-main-upgrade
)npm run build:webpack && npm run build:release
npm run test:js
Changelog entry
Changelog Entry Comment
Comment
Post merge