Skip to content

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Sep 12, 2025

Fixes STRIPE-446
Original PR #4264

Changes proposed in this Pull Request:

This is the main PR upgrading the extension Node version to 20. It is basically a recreation of #4264. The purpose is to keep the git history here cleaner, making it easier to review.

After upgrading many necessary packages, the ones we are upgrading here require Node 20, so they must go along with the main version change.

Testing instructions

  • Checkout to this branch on your test environment (dev/node-20-main-upgrade)
  • Confirm you can successfully build the frontend files for release: npm run build:webpack && npm run build:release
  • Perform some basic smoke-testing on the frontend
  • Confirm the frontend unit tests are still working: npm run test:js

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa marked this pull request as ready for review September 12, 2025 20:43
@wjrosa wjrosa requested review from a team, diegocurbelo and Mayisha and removed request for a team September 15, 2025 15:06
@wjrosa wjrosa mentioned this pull request Sep 15, 2025
12 tasks
Copy link
Member

@diegocurbelo diegocurbelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @wjrosa... Node 20 woohoo! 👏🏼 😄 👏🏼

The changes look good, and it works as expected:

  • all checks pass
  • tests run locally
  • npm start and npm run build work (both after update and with a clean install)
  • woorelease simulate generates a valid zip package

@@ -172,8 +175,8 @@
"changelog": "node bin/changelog.js"
},
"engines": {
"node": ">=16.17.0",
"npm": ">=8.15.0"
"node": ">=20.10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the same version as in the .nvmrc file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants