Explore post-confirm price recalculation for Amazon Pay #4768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards STRIPE-757
Towards #4750
Changes proposed in this Pull Request:
This PR explores adding some special logic for Amazon Pay when the store is configured to calculate taxes based on billing address. The core issue is that we are getting the shopper's address in the
confirmevent, and are then initiating checkout immediately. However, depending on the store's tax setup, this may cause the taxes in checkout to be different from the taxes we sent to Amazon which the user agreed to, as the user's tax rates may change. This results in the payment being declined.To try and address that problem, this PR does the following:
confirmevent for an express checkout method, we check if taxes are based on billing address and we have an Amazon Pay payment.This is not working at present, though it is updating the amount of the intent when we update the amount.
Testing instructions
Changelog entry
Changelog Entry Comment
Comment
Post merge