Skip to content

Conversation

jaclync
Copy link
Contributor

@jaclync jaclync commented Aug 8, 2025

For WOOMOB-1014
Just one review is required.

Description

Disables Wormholy shake gesture trigger to prevent accidental activation in production builds. Previously, Wormholy was only included in debug configurations with CocoaPods, but after migrating to SPM, the library is included in all configurations (attempts to exclude the library, still WIP). This change ensures merchants won't accidentally trigger the debugging tool through shake gestures.

Steps to reproduce

  1. Build the app in Release configuration (Edit Scheme > Run > Info > Build Configuration)
  2. Test shake gesture on device or simulator (Device > Shake)
  3. Verify Wormholy UI does not appear

Testing information

I tested in iPad Pro 11in iOS 18.5 simulator, and was able to repro the issue before the fix when running the app in Release configuration.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

dangermattic commented Aug 8, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.0. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@jaclync jaclync added this to the 23.0 milestone Aug 8, 2025
@jaclync jaclync added the type: bug A confirmed bug. label Aug 8, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15991-1da3f2d
Version22.9
Bundle IDcom.automattic.alpha.woocommerce
Commit1da3f2d
Installation URL298rce44ebag8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@jaclync jaclync requested a review from a team August 8, 2025 01:21
@iamgabrielma iamgabrielma self-assigned this Aug 8, 2025
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested on simulated iPhone 16 Plus - 18.3.1

@jaclync jaclync merged commit c443ed4 into trunk Aug 8, 2025
20 checks passed
@jaclync jaclync deleted the backlog/WOOMOB-1014-disable-wormholy-shake-trigger branch August 8, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants