[Woo POS][Historical Orders] Order Details: Email Receipt action - Update Order List and Order Details (2/2)

[staskus]

WOOMOB-1140

Description

Continuation of #16110, to update order list and order details after the receipt is sent:

• Fetch the order from the API after the receipt is sent
• In PointOfSaleOrderListController update the order list and the selected order
• Bonus: Improve POSButtonStyle to add a success state to the button that is shown in POSSendReceiptView when the receipt is successfully sent

Steps to reproduce

1. Open POS -> Menu -> Orders
2. Select a completed order
3. Select "Email receipt"
4. Confirm a loading state is shown when the email is being sent
5. Confirm a success state is shown when the email is sent
6. Confirm the view is automatically dismissed
7. Confirm new email details are reflected in the order list and order details views

Testing information

Tested on iPad Air 26.0 simulator

Screenshots

update.details.mov

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	pr16113-f31edba
	Version	23.2
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	f31edba
	Installation URL	3v2fm0le70gs8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[iamgabrielma]

Nice! LGTM

Some notes, not necessarily for this PR:

• Should refunded orders display the email receipt button? It does in the app, but not in POS.
• This seems an edge case: If an order is sent to X email, but then we assign a customer to the order and this happens to have a billing address, it will override it when rendering in order list, but not in order details. Note order 4305 at the top has different emails in each view.

For this I sent the receipt to X email address, then assigned a customer to the order which had a different email on their billing details.

[iamgabrielma]

Question: This could be an async wrapper for existing loadOrder, right? So no need to define the function specifically for POS orders

[staskus]

I first reused the existing method, but it's a bit awkward since it uses non-async version of enqueue that returns an optional Data? and optional Error? which requires to set some unknown` error state to make sure all the code paths are covered. Seemed cleaner to create this new async method.

[iamgabrielma]

Gotcha, sounds good to me! 🕺

[iamgabrielma]

I'm not sure if we discussed this previously, or if wasn't worth it due to the small data structures for POS, but do you think we want to make POSOrders and others GeneratedFakeable/Copiable?So we would only need to do things like POSOrder.fake().copy(customerEmail: "[email protected]")

[staskus]

Good advice. Done that 👍

[iamgabrielma]

Nit regarding test names to use _when_ABC_then_XYZ

[iamgabrielma]

Nice 💯

[staskus]

@iamgabrielma, thank you for the excellent review!

Should refunded orders display the email receipt button? It does in the app, but not in POS.

I think we should do it. I'll leave it for i2. We need to set a refund template in send_email API method. We also have a bunch of refund-related improvements for order details that we could stack together:

• Issue Refund action
• Refunded products in Order Details
• Email Receipt button for refunded orders

They will make sense as a separate refunds-related update.

This seems an edge case: If an order is sent to X email, but then we assign a customer to the order and this happens to have a billing address, it will override it when rendering in order list, but not in order details. Note order 4305 at the top has different emails in each view.

Good catch! That actually was an issue with how state is persisted in OrderListController where we didn't update selectedOrder when the order list data updated. Fixed that!