-
Notifications
You must be signed in to change notification settings - Fork 118
[CIAB] Hide blaze and stock cards from dashboard for CIAB sites #16116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIAB] Hide blaze and stock cards from dashboard for CIAB sites #16116
Conversation
|
249aab1
to
7e73f66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! 🚢
@@ -586,6 +615,7 @@ private extension DashboardViewModel { | |||
canShowGoogle: Bool, | |||
canShowAnalytics: Bool, | |||
canShowLastOrders: Bool, | |||
canSowStock: Bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: typo canShowStock
WOOMOB-1266
Description
Makes sure "Blaze" and "Stock" cards are hidden from Dashboard.
Also fixes a bug where blaze card wasn't appearing in dashboard until manually pulled-to-refresh.
BlazeCampaignDashboardViewModel
to rely on publishedstores.site
instead ofsessionManager.defaultSite
CIABEligibility
checker inBlazeCampaignDashboardViewModel
andDashboardViewModel
to determine cards visibilityDashboardViewModel
to rely on publishedstores.site
DashboardViewModelTests
andBlazeCampaignDashboardViewModelTests
Testing Steps
Testing information
Tested the above scenarios on iPhone Simulator 18.4. Added unit tests covering the behaviour.
RELEASE-NOTES.txt
if necessary.