Skip to content

[Tooling] Fail on Version Mismatch Between ReleasesV2 and Project #22324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+10 −8
Open

[Tooling] Fail on Version Mismatch Between ReleasesV2 and Project #22324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions fastlane/lanes/release.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,17 @@
computed_version = next_release_version
new_version = version || computed_version

# Warn if provided version differs from computed version
# Fail if provided version differs from computed version
if version && version != computed_version
warning_message = <<~WARNING
⚠️ Version mismatch: The explicitly-provided version was '#{version}' while new computed version would have been '#{computed_version}'.
If this is unexpected, you might want to investigate the discrepency.
Continuing with the explicitly-provided verison '#{version}'.
WARNING
UI.important(warning_message)
buildkite_annotate(style: 'warning', context: 'code-freeze-version-mismatch', message: warning_message) if is_ci
error_message = <<~ERROR
❌ Version mismatch detected!

The explicitly-provided version from the release tool is '#{version}' but the computed version from the codebase is '#{computed_version}'.

This mismatch must be resolved before proceeding with the code freeze. Please investigate and ensure the versions are aligned.
ERROR
buildkite_annotate(style: 'error', context: 'code-freeze-version-mismatch', message: error_message) if is_ci
UI.user_error!(error_message)
end

message = <<-MESSAGE
Expand Down