-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CMM-930: Improve the video thumbnails in conversations #22340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
CMM-930: Improve the video thumbnails in conversations #22340
Conversation
Generated by 🚫 Danger |
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22340-ddce77e | |
| Commit | ddce77e | |
| Direct Download | wordpress-prototype-build-pr22340-ddce77e.apk |
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22340-ddce77e | |
| Commit | ddce77e | |
| Direct Download | jetpack-prototype-build-pr22340-ddce77e.apk |
WordPress/src/main/java/org/wordpress/android/support/he/ui/AttachmentFullscreenVideoPlayer.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/he/ui/AttachmentFullscreenVideoPlayer.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/he/util/VideoUrlResolver.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/he/util/VideoUrlResolver.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/he/util/VideoUrlResolver.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/he/util/VideoUrlResolver.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/he/ui/AttachmentFullscreenVideoPlayer.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/support/he/ui/HEConversationDetailScreen.kt
Outdated
Show resolved
Hide resolved
…nversations' of https://github.com/wordpress-mobile/WordPress-Android into feat/CMM-930-support-Improve-the-video-thumbnails-in-conversations
|
Claude finished @adalpari's task —— View job PR Review SummaryTodo List:
Great work addressing the previous review comments! I can see you've made excellent improvements in commit ✅ Issues Resolved
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #22340 +/- ##
==========================================
- Coverage 39.21% 39.15% -0.07%
==========================================
Files 2201 2203 +2
Lines 105788 105955 +167
Branches 15009 15024 +15
==========================================
Hits 41485 41485
- Misses 60811 60978 +167
Partials 3492 3492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jkmassel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked as described on-device.





Description
This PR is improving the UX when browsing a video attachment in a support ticket.
The user can now see a video-thumbnail and preview it inside the app.
I noticed we are not using the more modern ExoPlayer library (it's not a version problem, but a library one), so I had to add an OkHttp workaround to fix the limitations the current library has with authentication redirections.
So, if we see problems playing the videos I would suggest to skip full-screen videos until we migrate to the new library.
Testing instructions
Screen_recording_20251105_170325.mp4