Skip to content

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Sep 12, 2025

This removes all the commands for setting extension settings. I don't think people really use the settings commands, and the fact that VS Code has a GUI settings editor (which apparently it didn't when this extension was made because it's that old) makes these commands redundant. Note that this does not remove commands for setting the WPILib preferences JSON, because there's no GUI editor for that, although I doubt those commands get much usage...

@github-actions github-actions bot added the 2027 label Sep 12, 2025
@sciencewhiz
Copy link
Contributor

I think this cleans up the menu, but the documentation will need to be updated, probably by making a new section for the extension preferences.

@Gold856
Copy link
Contributor Author

Gold856 commented Sep 19, 2025

I noticed there was a setting for selecting all simulation extensions by default, but it seems to not be implemented. This functionality technically exists already by just modifying build.gradle with .defaultEnabled = true added to any added extensions. Should we remove the setting in favor of modifying build.gradle, or should we implement the setting?

@sciencewhiz
Copy link
Contributor

I noticed there was a setting for selecting all simulation extensions by default, but it seems to not be implemented. This functionality technically exists already by just modifying build.gradle with .defaultEnabled = true added to any added extensions. Should we remove the setting in favor of modifying build.gradle, or should we implement the setting?

I seem to recall it working in the past, but not necessarily being intuitive as to what it was doing.

@Gold856
Copy link
Contributor Author

Gold856 commented Oct 16, 2025

Given the lack of implementation, lack of reports of said implementation, and an alternative way to replicate its functionality, I'm just gonna remove it.

@PeterJohnson PeterJohnson merged commit 5730f70 into wpilibsuite:2027 Oct 17, 2025
5 checks passed
@Gold856 Gold856 deleted the remove-settings-change-commands branch October 20, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants