Skip to content

Defer building code when vendor instructions shown #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

Defer building code when vendor instructions shown #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions vscode-wpilib/src/dependencyView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export class DependencyViewProvider implements vscode.WebviewViewProvider {
private vendordepMarketplaceURL = `https://frcmaven.wpi.edu/artifactory/vendordeps/vendordep-marketplace/`;
private wp: vscode.WorkspaceFolder | undefined;
private changed = 0;
private showingInstructions = false;

private _view?: vscode.WebviewView;

Expand Down Expand Up @@ -92,7 +93,9 @@ export class DependencyViewProvider implements vscode.WebviewViewProvider {
if (webviewView.visible) {
void this._refresh(this.wp);
} else {
if (this.changed > this.vendorLibraries.getLastBuild()) {
if (this.showingInstructions) {
this.showingInstructions = false;
} else if (this.changed > this.vendorLibraries.getLastBuild()) {
this.externalApi.getBuildTestAPI().buildCode(this.wp, undefined);
this.changed = 0;
}
Expand Down Expand Up @@ -127,7 +130,9 @@ export class DependencyViewProvider implements vscode.WebviewViewProvider {
}
case 'blur': {
if (this.wp) {
if (this.changed > this.vendorLibraries.getLastBuild()) {
if (this.showingInstructions) {
this.showingInstructions = false;
} else if (this.changed > this.vendorLibraries.getLastBuild()) {
this.externalApi.getBuildTestAPI().buildCode(this.wp, undefined);
this.changed = 0;
}
Expand Down Expand Up @@ -234,6 +239,7 @@ export class DependencyViewProvider implements vscode.WebviewViewProvider {

if (success) {
if (avail.instructions) {
this.showingInstructions = true;
await vscode.commands.executeCommand(
'extension.showWebsite',
avail.instructions,
Expand Down