Skip to content

Conversation

@mirekand
Copy link

@mirekand mirekand commented Oct 3, 2025

Fix issues found when building WRF-CHEM with CCE compiler

TYPE: no impact

KEYWORDS: CCE,errors,module_optical_averaging.F,module_mosaic_addemiss.F,Cray

SOURCE: Miroslaw Andrejczuk (HPE)

DESCRIPTION OF CHANGES:
Problem:
There were few errors reported by Cray compiler when building WRF-CHEM code. In chem/module_optical_averaging.F comma after write statements triggered error when building, and for chem/module_mosaic_addemiss.F compiler complained that because subroutine mosaic_dust_gocartemis has an optional argument an interface to this routine is needed in module itself.

Solution:
Remove commas after write statements in module_optical_averaging.F. Move END MODULE module_mosaic_addemiss statement in the file to include subroutine mosaic_dust_gocartemis in the module definition.

ISSUE: For use when this PR closes an issue.
Fixes #2252

LIST OF MODIFIED FILES:
chem/module_mosaic_addemiss.F
chem/module_optical_averaging.F

TESTS CONDUCTED:

  1. With those changes I can build wrf/em_real with CCE
  2. Are the Jenkins tests all passing? Wasn't run

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

@mirekand mirekand requested a review from a team as a code owner October 3, 2025 08:24
@weiwangncar
Copy link
Collaborator

@mirekand Thanks for making the PR!

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@islas islas changed the base branch from master to develop October 21, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues when building WRF-CHEM with CCE

2 participants