Merge poolfactory upgrade, update upgrade script #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CryptITAustria
commented
Jan 24, 2025
CryptITAustria
commented
- merge poolfactory 4 with 3 into the same upgrade
- update the upgrade script to upgrade for voting in addition to transfer keys
craigbranscom
approved these changes
Jan 24, 2025
| const EsXai4 = await ethers.getContractFactory("esXai4"); | ||
| console.log("Got PoolFactory factory"); | ||
| const esXai4 = await upgrades.upgradeProxy(ESXAI_ADDRESS, EsXai4, { call: { fn: "initialize", args: [XAI_VOTING_CONTRACT_ADDRESS] } }); | ||
| console.log("PoolFactory upgraded to version 3"); |
There was a problem hiding this comment.
These logs reference pool factory but are deploying esXai4 and Xai2
There was a problem hiding this comment.
Thakns updated the logs
| const ESXAI_ADDRESS = config.esXaiAddress; | ||
| const XAI_ADDRESS = config.xaiAddress; | ||
|
|
||
| const XAI_VOTING_CONTRACT_ADDRESS = ""; |
There was a problem hiding this comment.
Will need to set this but looks like this is expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.