Skip to content

Remove xfail mark for False case in test_batch_3d_1d_input due to resolved bug #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove xfail mark for False case in test_batch_3d_1d_input due to resolved bug #243

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8998676
Remove xfail mark for False case in test_batch_3d_1d_input due to res…
andersy005 Oct 9, 2024
0262233
Merge branch 'main' into fix-dim-ordering-bug
andersy005 Oct 10, 2024
721e403
Add False case to test_batch_3d_1d_input_batch_dims
andersy005 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions xbatcher/tests/test_generators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,7 @@ def test_batch_3d_1d_input(sample_ds_3d, input_size):
'concat',
[
True,
pytest.param(
False,
marks=pytest.mark.xfail(
reason='Bug described in https://github.com/xarray-contrib/xbatcher/issues/126'
),
),
False,
],
)
def test_batch_3d_1d_input_batch_dims(sample_ds_3d, concat):
Expand Down
Loading