[AdaptiveStream] A couple of fixes after the refactor PR #1902 #1910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevent wrong buffer data accesses if demuxer try to read
…ken download This restore previous behavior for subtitle case so if a single segment fail to download continue with next segments instead to stop the stream with EOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple of fixes after the refactor PR #1902
this should be also a final fix to issue #1645,
in my tests now if the audio stream segments cant be downloaded
the audio stream will be set as EOS and stop to feed kodi demuxer
this will cause that on playback the video can still be played but without audio (and without loud audio stuttering due to broken segments)
fix #1645
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Types of change
Checklist: