-
-
Notifications
You must be signed in to change notification settings - Fork 836
Replace defaultProps #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Replace defaultProps #538
Conversation
@xcarpentier Could you help merge these changes or assign someone to do so? Seems all checks have passed. Thx |
Please merge, thank you! |
If it's not merged soon I will create a @vricosti/react-native-country-picker-modal package as I already did for some unmaintained package (@vricosti/react-native-asset). |
I tried to generate on my fork and I have ts errors:
so what about:
{...props} already includes placeholder and autoFocus because it's built from CountryFilterProps. |
Hi Can this get merged please? @xcarpentier |
Merged here: https://github.com/vricosti/react-native-country-picker-modal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xcarpentier This is a really simple change that will help a lot of people who are using libraries that depend on this. Please can you merge, it's only a few lines of changes?
Fixes issues with
defaultProps
, which is incompatible with 0.78 / React 19 and throws an error.Fixes #536
Fixes #526
Fixes #535
Duplicates (sorry, I didn't see them)
Duplicate of #531
Duplicate of #529