lib/host: Avoid using identical source and destination paths in execute_script scp

[rushikeshjadhav]

Using the same path for both source and destination may cause scp to fail, especially when the source path (e.g. a temp path on macOS) does not exist on the remote system. Thus, resorting to use mktemp on destination.

[ydirson]

better use os.path.basneame

[rushikeshjadhav]

thanks, made the change.

[stormi]

Ping @ydirson

[ydirson]

Better, but computing the same path 3 times is suboptimal also for reading :)

[Millefeuille42]

Instead of computing paths each time, you could eventually use mktemp on the remote:

(Like in a fixture here)

@pytest.fixture(scope="module")
def temp_dir(running_unix_vm):
    vm = running_unix_vm
    tempdir = vm.ssh("mktemp -d")

    yield tempdir

    # teardown
    vm.ssh(f"rm -r {tempdir}")

Or something like this for local use:

import tempfile

### Either using contexts
with tempfile.TemporaryDirectory() as tmpdirname:
     print('created temporary directory', tmpdirname)

### Either controlling the lifetime manually
temp_dir = tempfile.TemporaryDirectory()
print(temp_dir.name)
temp_dir.cleanup()

This is for dirs but is quite the same for files.

[ydirson]

I like this fixture :)

[Millefeuille42]

Straight up borrowed from #324 😁
It could be great to have this kind of generic fixtures available for all tests 👀 (eventually platform agnostic unlike the one I suggested)

[rushikeshjadhav]

Thanks, please see the latest update if it works.

[Millefeuille42]

it's all good for me

[Wescoeur]

Should probably be moved in try scope in case for some reason a call fails even if unlikely.

[rushikeshjadhav]

Sure, have moved them.