Don't uninstall sr tools on failed teardown #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klmp200
force-pushed
the
abartuc/sr-teardown
branch
2 times, most recently
from
3287421 to
b10d6d5
Compare
|
A PR title is important. It's our first contact with the change. Here, it looks like the title currently says the contrary of what the PR actually does :) |
klmp200
changed the title
Indeed, it does, I made a typo writing it ^^' That's fixed I'll add a proper description once I'm done with the content of the PR, it's not ready yet :) |
klmp200
force-pushed
the
abartuc/sr-teardown
branch
from
b10d6d5 to
46cd8ab
Compare
glehmann
approved these changes
Oct 9, 2025
stormi
reviewed
Oct 10, 2025
Leave glusterfs tools in place for manual cleanup after a failed SR cleanup Signed-off-by: Antoine Bartuccio <[email protected]>
Leave linstor tools in place for manual cleanup after a failed SR cleanup Signed-off-by: Antoine Bartuccio <[email protected]>
Leave xfs tools in place for manual cleanup after a failed SR cleanup Signed-off-by: Antoine Bartuccio <[email protected]>
klmp200
force-pushed
the
abartuc/sr-teardown
branch
from
51d6dd5 to
db8d29c
Compare
glehmann
approved these changes
Oct 14, 2025
stormi
approved these changes
Oct 14, 2025
Wescoeur
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SR cleanup fails on linstor and glusterfs tests, a manual cleanup is needed.
Since tests removes software tools needed to interact with those technologies, we have to install them again to cleanup and it's annoying.
This PR ensures that those tools are still installed on the host machine when this scenario happens