Skip to content

file name & URL validation patch #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

file name & URL validation patch #31

wants to merge 5 commits into from

Conversation

nrv
Copy link

@nrv nrv commented Jul 7, 2022

The file name should be coherent with the class it contains (upper / lower case)

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nrv nrv changed the title file name coherent with class name (upper/lower case) file name & URL validation patch Jul 7, 2022
@zacmos
Copy link
Contributor

zacmos commented Jul 8, 2022 •
edited
Loading

Thank you for the PR,
As mentioned in the issue, the fix will be done in the API response and not as part of the SDK.
Regarding the files names, the code is generated out of the Twitter OpenAPI spec therefore there is no option to submit PRs at the moment. This may be changed in the future.

@zacmos zacmos marked this pull request as draft July 8, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrv @CLAassistant @zacmos