fixes for non-avx targets #239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when emulating avx for non-avx targets, the _m256i type is being typedef'd, however, this type is defined in avxintrin.h which is only included via immintrin.h if avx is enabled. I've added an inline definition that seems to work on my x86_64 machine with clang when __AVX__ is not defined. Also, mm256_maddubs_epi16 was unable to compile for non-avx targets, I've addressed this by only defining this function when either __AVX2__ or __SSSE3__ is defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when emulating avx for non-avx targets, the
_m256itype is being typedef'd, however, this type is defined inavxintrin.hwhich is only included viaimmintrin.hif avx is enabled. I've added an inline definition that seems to work on my x86_64 machine with clang when__AVX__is not defined.Also,
mm256_maddubs_epi16was unable to compile for non-avx targets, I've addressed this by only defining this function when either__AVX2__or__SSSE3__is defined.