chore: Avoid using SMTP sever on development #51
+1,341
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmachin
requested review from
mlvieras,
lauta2912,
MBerguer and
chaba11
as code owners
mlvieras
reviewed
Jan 19, 2024
src/config/config.ts
Outdated
Comment on lines
29
to
30
| if (process.env.NODE_ENV === 'production') return !!val; | ||
| return true; |
There was a problem hiding this comment.
Suggested change
| if (process.env.NODE_ENV === 'production') return !!val; | |
| return true; | |
| return process.env.NODE_ENV !== 'production' || val; |
src/emails/index.ts
Outdated
| import { config } from 'config/config'; | ||
| import { config, isProduction } from 'config/config'; | ||
|
|
||
| const emailTransporter = nodemailer.createTransport({ |
There was a problem hiding this comment.
Shouldn't this also be hidden depending on the environment?
There was a problem hiding this comment.
By hidden do you mean something like this?
Suggested change
| const emailTransporter = nodemailer.createTransport({ | |
| const emailTransporter = isProduction | |
| ? nodemailer.createTransport({ | |
| host: config.smtpHost, | |
| port: config.smtpPort, | |
| auth: { | |
| user: config.smtpUser, | |
| pass: config.smtpPassword, | |
| }, | |
| }) | |
| : null; |
mlvieras
reviewed
Jan 19, 2024
src/config/config.ts
Outdated
| .refine((val) => { | ||
| if (process.env.NODE_ENV === 'production') return !Number.isNaN(val); | ||
| return true; | ||
| return process.env.NODE_ENV !== 'production' || val; |
There was a problem hiding this comment.
Would you mind updating all other cases with this? Also, I think we can change this to implicit return
mlvieras
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTION Ticket
Type of change
Description of the change
Used
preview-emailpackage to avoid using a SMTP service on development and testing, also update config schema to not need to configure SMTP environment vars on development and testing.