rebase #4772
Open
rebase #4772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: fix rendering of the plots in the heat equation example
Hotfix nonlinlap
…known upstream issue
Add discrete callbacks
[WIP] Better staggered implementation
…9-12-11-26-776-02761606696 CompatHelper: bump compat for ModelingToolkit to 10 for package docs, (keep existing compat)
refactor: do not use `getproperty` to access system fields
fix broken link to PDESystem
This removes the Invalidations.yml workflow file as it is no longer needed.
Add spell checking configuration
This adds the standardized downgrade CI workflow following the SciMLBase.jl template to test package compatibility with downgraded dependencies. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add downgrade CI workflow
## Spelling Corrections (17 fixes across 12 files) ### Documentation and Comments - Fix 'sensetive' → 'sensitive' in WENO scheme documentation - Fix 'Retriving' → 'Retrieving' in tutorial documentation - Fix 'consise' → 'concise' in developer notes - Fix 'independant' → 'independent' in documentation (2 instances) - Fix 'genral' → 'general' in finite difference rules - Fix 'nessecary/nessesary' → 'necessary' in TODO comments (2 instances) - Fix 'assymmetry' → 'asymmetry' in interior mapping TODO - Fix 'faliures' → 'failures' in system transformation comment - Fix 'sustem' → 'system' in test comment ### Test Files - Fix 'origial' → 'original' in nonlinear diffusion tests (4 instances) ### Error Messages - Fix 'independant' → 'independent' in user-facing error message ## Configuration Enhancement Enhanced .typos.toml to recognize legitimate Method of Lines terminology: - **`dorder/dorders`**: Derivative order (core mathematical concept) - **Numerical methods**: upwind, downwind, stencil, gridpoint terms - **PDE terminology**: discretization, discretizer, pdesys, ivs, bcs, ics - **Type parameters**: Strat (Strategy abbreviation) ## Preserved Technical Terms All legitimate mathematical and numerical methods terminology preserved: - `dorder` (derivative order) - used 9 times correctly throughout codebase - Standard PDE and finite difference method vocabulary - Julia/SciML ecosystem conventions This maintains domain expertise while improving code quality and user experience. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fix spelling errors and enhance spell checking configuration
Run JuliaFormatter on all Julia source files to ensure consistent code formatting across the repository. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Apply JuliaFormatter to codebase
The documentation for `grid_align` parameter in MOLFiniteDifference had broken links to CenterAlignedGrid and EdgeAlignedGrid. The parentheses in the link text were causing Documenter.jl to generate incorrect URLs leading to 403 Forbidden errors. This commit removes the parentheses from the link text to fix the issue. Fixes #463 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fix broken documentation links for grid alignment types
- Fix path handling in make.jl to work from both root and docs directory - Fix broken example in sispde.md by adding error handling for failed steady state solve - Update broken JuliaHub compiler documentation link - Create assets directory if it doesn't exist These changes address the documentation build failures seen in Buildkite CI. The main issue was that make.jl assumed it was run from the root directory, but Buildkite runs it from the docs directory. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
As requested, reverting the path handling changes in make.jl and removing the generated Project.toml file from assets. The documentation build issues will need to be addressed differently. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The episize! function was using 'state' as the variable name for the solution object, but it should be 'steadystate' to be consistent with the rest of the document and to properly work with solution indexing. The solve() function returns a solution object that can be indexed directly, so we just need to use the correct variable name. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Fix documentation build errors in Buildkite CI
docs: remove mention of JuliaSimCompiler
…eep existing compat)
…6-07-10-55-496-00625432201 CompatHelper: bump compat for SymbolicUtils to 4 for package docs, (keep existing compat)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.