PHP 7.3 #162
Open
PHP 7.3 #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this adds composer.json and composer.lock generated by the same php version that will be used on heroku
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Vagrant development environment to install and use PHP 7.3 (7.3.11 at the time of the PR), which is the same PHP version
^7.3will result in running on Heroku.The
composer.jsonis updated to reflect^7.3andcomposer.lockfile is generated from the Vagrant install to match so Heroku won't throw any warnings like in #104.If you test this using macOS, take a look at #161 if composer fails, that probably won't be related to this PR.