Skip to content

Update /lsp-examples/zig/install.py installation script and eliminate errors from the flag '-Drelease-safe' #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update /lsp-examples/zig/install.py installation script and eliminate errors from the flag '-Drelease-safe' #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
392dcd3
Update /lsp-examples/zig/install.py
arnoldmashava Feb 15, 2025
e0ce45b
Update install.py
arnoldmashava Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion zig/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,15 @@ def Main():
subprocess.check_call( [ git, 'clone', '--recurse-submodules', '--depth=1', url ] )
os.chdir('zls')

subprocess.check_call( [ zig, 'build', '-Drelease-safe'])
# The flag '-Doptimize=ReleaseSafe' is specified in the zls source code Documentation
# https://github.com/zigtools/zls/blob/master/README.md
# The other flag '-Dversion-string=<Semantic Version>' was being required by the build automation process
# When it was failing to run git for the description and resolution of the ZLS Version and Tags from
# the source code repository
# The assigned Version of '0.14.0-dev.390+188a4c04' was obtained from a separately built zls binary
# for x86_64 Linux
# A more permanent and prettier solution is required, but this should suffice in the interim
subprocess.check_call( [ zig, 'build', '-Doptimize=ReleaseSafe', '-Dversion-string=0.14.0-dev.390+188a4c04'])


if __name__ == '__main__':
Expand Down