Skip to content

Remove connection from pool before waiting for results #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Remove connection from pool before waiting for results #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ydb/aio/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ async def connection_ready(self, ready_timeout=10):

await asyncio.wait_for(self._channel.channel_ready(), timeout=ready_timeout)

async def close(self, grace: float = None):
async def close(self, grace: float = 30):
"""
Closes the underlying gRPC channel
:param: grace: If a grace period is specified, this method wait until all active
Expand All @@ -239,12 +239,12 @@ async def close(self, grace: float = None):

self.closing = True

if self.calls:
await asyncio.wait(self.calls.values(), timeout=grace)

for callback in self._cleanup_callbacks:
callback(self)

if self.calls:
await asyncio.wait(self.calls.values(), timeout=grace)

await self.destroy()

async def __aenter__(self):
Expand Down
Loading