Skip to content

Replace codec to RAW if not specified #10272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Replace codec to RAW if not specified #10272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
607a6d6
Replace topic to raw in pq_v1 and topics
niksaveliev Oct 10, 2024
ae85998
fix
niksaveliev Oct 10, 2024
b2cb6b0
fix
niksaveliev Oct 14, 2024
c7b3460
fix
niksaveliev Oct 14, 2024
8de431e
fix
niksaveliev Oct 14, 2024
6d70f34
fix
niksaveliev Oct 14, 2024
e7e0197
fix
niksaveliev Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ydb/core/persqueue/dread_cache_service/caching_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,10 @@ class TPQDirectReadCacheService : public TActorBootstrapped<TPQDirectReadCacheSe
continue; //TODO - no such chunks must be on prod
}

if (!proto.has_codec()) {
proto.set_codec(NPersQueueCommon::RAW);
}

TString sourceId;
if (!r.GetSourceId().empty()) {
sourceId = NPQ::NSourceIdEncoding::Decode(r.GetSourceId());
Expand Down
5 changes: 5 additions & 0 deletions ydb/services/deprecated/persqueue_v0/grpc_pq_read_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2137,6 +2137,11 @@ void TPartitionActor::Handle(TEvPersQueue::TEvResponse::TPtr& ev, const TActorCo
if (proto.GetChunkType() != NKikimrPQClient::TDataChunk::REGULAR) {
continue; //TODO - no such chunks must be on prod
}

if (!proto.has_codec()) {
proto.set_codec(NPersQueueCommon::RAW);
}

TString sourceId = "";
if (!r.GetSourceId().empty()) {
if (!NPQ::NSourceIdEncoding::IsValidEncoded(r.GetSourceId())) {
Expand Down
5 changes: 5 additions & 0 deletions ydb/services/persqueue_v1/actors/partition_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,11 @@ bool FillBatchedData(
hasOffset = true;

auto proto(GetDeserializedData(r.GetData()));

if (!proto.has_codec()) {
proto.set_codec(NPersQueueCommon::RAW);
}

if (proto.GetChunkType() != NKikimrPQClient::TDataChunk::REGULAR) {
continue; //TODO - no such chunks must be on prod
}
Expand Down
2 changes: 1 addition & 1 deletion ydb/services/persqueue_v1/actors/read_session_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,6 +1739,7 @@ i64 TFormedReadResponse<TServerMessage>::ApplyResponse(TServerMessage&& resp) {
return ByteSize - prev;
}


template <typename TServerMessage>
i64 TFormedReadResponse<TServerMessage>::ApplyDirectReadResponse(TEvPQProxy::TEvDirectReadResponse::TPtr& ev) {

Expand All @@ -1755,7 +1756,6 @@ i64 TFormedReadResponse<TServerMessage>::ApplyDirectReadResponse(TEvPQProxy::TEv
return diff;
}


template <bool UseMigrationProtocol>
void TReadSessionActor<UseMigrationProtocol>::Handle(typename TEvReadResponse::TPtr& ev, const TActorContext& ctx) {
if (!ActualPartitionActors.contains(ev->Sender)) {
Expand Down
Loading